feat: rtl for tables#3227
Open
artem-harbour wants to merge 2 commits into
Open
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
artem-harbour
force-pushed
the
artem/rtl-v6
branch
from
874e31e to
688659e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artem-harbour
force-pushed
the
artem/rtl-v6
branch
from
688659e to
1c72d03
Compare
artem-harbour
force-pushed
the
artem/rtl-v6
branch
from
1c72d03 to
460369c
Compare
…dex convention Two review-fix changes on the table-RTL stability work: 1. resize-move / resize-end events now emit the LOGICAL delta (the value applied to newWidths), restoring the pre-PR contract for external listeners (logging, analytics, undo metadata). The visual delta still lives on dragState.constrainedDelta for the in-flight preview guideline at line 591. LTR consumers see no behavior change; RTL inner-boundary consumers no longer see a sign-flipped payload. 2. Added a load-bearing comment at the right-edge boundary push explaining why the reported columnIndex is 0 in RTL and columns.length - 1 in LTR. Downstream consumers that need 'is this the outer edge?' should key off type === 'right-edge', not on the numeric column index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: SD-2810
Phase 5 (RTL Table Stability) is now completed for RTL table interaction and roundtrip reliability.
This PR does not introduce RTL tables from scratch; core support was already in place.
The main work here was stabilization and regression coverage:
bidiVisualpipeline behavior (<w:bidiVisual/>↔tableProperties.rightToLeft)Overall result: RTL tables are now covered by explicit tests across rendering, interaction, and export paths, with resize/drag behavior stabilized and regression-protected.